fix(installer): never write a broken global Kiro --path#76
Merged
Conversation
Kiro CLI does not expand ${workspaceFolder} in mcp.json args, so the v0.15.7
global install wrote `--path ${workspaceFolder}`, which resolved to the literal
`$HOME/${workspaceFolder}` and made the watcher and catch-up sync fail.
- A global Kiro install now writes NO MCP entry and self-heals by removing any
stale codegraph entry a prior version left (other MCP servers are kept).
- It emits explicit guidance to run `codegraph install --target=kiro --local`
from each project root, which still pins the project's absolute --path.
- Local installs are unchanged: concrete --path = project root.
- docs(cli): rewrite the Kiro section to match (global = guidance-only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.15.7 made a global Kiro install write
--path ${workspaceFolder}. But Kiro CLI does not expand${workspaceFolder}inmcp.jsonargs (only Kiro IDE does), so the arg resolved to the literal$HOME/${workspaceFolder}— the watcher and catch-up sync then failed withread dir /config/${workspaceFolder}.This makes the global path safe and keeps the working local path:
codegraphentry a prior version wrote (other MCP servers are preserved). Emits explicit guidance to runcodegraph install --target=kiro --localper project.--path.${workspaceFolder}).Zombie
<defunct>MCP children observed in Kiro are a Kiro client-side reaping defect (the parent doesn'twait()/forward SIGTERM to its stdio child on session end), not a codegraph issue — our detached daemonsetsids and reparents to init, and already self-shuts on stdin EOF / host-pid liveness. No code change here for that.Verification
make cigreen locally (fmt + clippy-D warnings+ full workspace test + guardrail); pre-push gate green.--path=cwd; global writes no codegraph entry and emits per-project guidance.--path <project>; global on clean home → no entry + guidance note; global self-heal → seeded broken${workspaceFolder}entry removed, unrelated server kept.